SoundWire: fix Dell SKU 0A45 - #3162
Merged
plbossart merged 2 commits intoSep 29, 2021
Merged
Conversation
plbossart
force-pushed
the
sdw/fix-dell-sku-0A45
branch
from
September 16, 2021 23:10
3a0d160 to
8bfbb3d
Compare
We don't have a configuration for a single amp on link1. BugLink: thesofproject#3161 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This device is based on SDCA codecs but with a single amplifier instead of two. BugLink: thesofproject#3161 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/fix-dell-sku-0A45
branch
from
September 20, 2021 15:57
8bfbb3d to
7f0513f
Compare
plbossart
marked this pull request as ready for review
September 28, 2021 15:24
plbossart
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood and
ranj063
as code owners
September 28, 2021 15:24
Member
Author
|
We can merge this now that issue #3181 is fixed. |
Member
Author
|
@bardliao @RanderWang can you please take a look? |
plbossart
added a commit
to plbossart/sof
that referenced
this pull request
Sep 28, 2021
Same as before but with newer SDCA codecs. Matching kernel PR: thesofproject/linux#3162 BugLink: thesofproject/linux#3161 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
bardliao
reviewed
Sep 29, 2021
| .link_mask = 0xF, /* 4 active links required */ | ||
| .links = tgl_3_in_1_sdca_mono, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-tgl-rt711-l0-rt1316-l1-mono-rt714-l3.tplg", |
Collaborator
There was a problem hiding this comment.
What does -10, -11, and -13 mean here?
Collaborator
There was a problem hiding this comment.
Sorry, please forget my previous comment. That is alphabet l, not number 1. It must be sdw link. I need a new glasses.
bardliao
approved these changes
Sep 29, 2021
lgirdwood
pushed a commit
to thesofproject/sof
that referenced
this pull request
Sep 29, 2021
Same as before but with newer SDCA codecs. Matching kernel PR: thesofproject/linux#3162 BugLink: thesofproject/linux#3161 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BIOS points to a combination of RT1316 (SDCA) and RT1308 (non-SDCA) and the kernel reports bus clashes on link2.
This could be a mistake with just a mono amp on link1.
Let's try this theory.
Fixes: #3161